Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixing formating and linting across the website code #541

Closed
wants to merge 20 commits into from
Closed

Fix: Fixing formating and linting across the website code #541

wants to merge 20 commits into from

Conversation

DhairyaMajmudar
Copy link
Contributor

What kind of change does this PR introduce?

Formats the code files.

Issue Number:
#539

Screenshots/videos:
N/A

If relevant, did you update the documentation?

N/A

Summary
Code files are now formatted

@DhairyaMajmudar DhairyaMajmudar requested a review from frouioui as a code owner May 1, 2024 04:55
@Gmin2
Copy link
Contributor

Gmin2 commented May 1, 2024 •
edited
Loading

In my opinion we should add a script here that enforces linting and check on every new PR created through github actions,
And mentioned it in the contribuding guide to run the lint command before submitting a PR.
In this way we dont have to do this manually all the time, the actions will fail if the changes pushed does not have linting

cc @frouioui views?

@DhairyaMajmudar
Copy link
Contributor Author

That's indeed a very good idea if @frouioui approves add that implementation in the PR

@frouioui
Copy link
Member

frouioui commented May 2, 2024

I think we should do what @utnim2 mentioned

@DhairyaMajmudar
Copy link
Contributor Author

Sure will work on this 💯

@DhairyaMajmudar
Copy link
Contributor Author

@frouioui I have added the script npm run format using which the files can be formatted. Also updated the readme.md file : )

frouioui
frouioui requested changes May 6, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To come back on what @utnim2 was saying, I think we should make this a CI check on every PR just like what we have in .github/workflows/golang_lint.yaml.

@DhairyaMajmudar
Copy link
Contributor Author

To come back on what @utnim2 was saying, I think we should make this a CI check on every PR just like what we have in .github/workflows/golang_lint.yaml.

Sure looking forward to add lint CI

@DhairyaMajmudar DhairyaMajmudar requested a review from frouioui May 8, 2024 20:26
frouioui
frouioui reviewed May 9, 2024
View reviewed changes
.github/workflows/typescript_lint.yaml Outdated
@@ -0,0 +1,53 @@
name: PR Workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the workflow should be more descriptive 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good catch : D

I have improved this in my recent commit.

frouioui
frouioui reviewed May 9, 2024
View reviewed changes
.github/workflows/typescript_lint.yaml Outdated

jobs:
linting_and_type-checking:
name: Linting, Formatting and Type checking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name as well, we should mention it is related to react/ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done this one also : )

@DhairyaMajmudar DhairyaMajmudar requested a review from frouioui May 9, 2024 18:27
frouioui and others added 18 commits May 19, 2024 21:53
@frouioui @DhairyaMajmudar
Fix performance issue on the status page
f4d03c8 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui @DhairyaMajmudar
optimize queue to only run the latest
47b10e9 
Signed-off-by: Florent Poinsard <[email protected]>
@Gmin2 @DhairyaMajmudar
make the table of status page responsive
46b6f29
@Gmin2 @DhairyaMajmudar
fixed the width of full screen and added config for medium screen
fe52fff
@Gmin2 @DhairyaMajmudar
removed the bug of not showing the table completely
7865097
@DhairyaMajmudar
replacing twitter logo
8819e65
@DhairyaMajmudar
adding types in SearchPage components
fdc1bdf
@DhairyaMajmudar
adding pr and issue templates
b3a5a56
@frouioui @DhairyaMajmudar
Update .github/ISSUE_TEMPLATE/bug_report.yml
8024c36 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui @DhairyaMajmudar
Update .github/ISSUE_TEMPLATE/feature_request.yml
1a7a2a6 
Signed-off-by: Florent Poinsard <[email protected]>
@DhairyaMajmudar
shifting in tailwindcss
eb00810
@DhairyaMajmudar
suggested cahnge
d8d7e2e
@DhairyaMajmudar
suggested changes
0fdedd0
@DhairyaMajmudar
converting into shadcn buttons
6d09137
@DhairyaMajmudar
text-color fix
97491c3
@DhairyaMajmudar
text-color fix
5f89289
@DhairyaMajmudar
fixing format and lint
4f7b3f6 
adding format script and updating readme

updating readme

adding lint check workflow

fixing path

work dir fix

work dir fix

fix
@DhairyaMajmudar
workdir
f8e31b0
@DhairyaMajmudar
parent f8e31b0
cea9c68 
author Dhairya Majmudar <[email protected]> 1715198956 +0530
committer Dhairya Majmudar <[email protected]> 1716135857 +0530

fix

adding format script and updating readme

updating readme

work dir fix

work dir fix

fix

workdir

removing commit
@DhairyaMajmudar
Re:workflow name
34d4c23
@DhairyaMajmudar DhairyaMajmudar deleted the lintFix branch May 19, 2024 16:32
@DhairyaMajmudar
Copy link
Contributor Author

Moving changes to PR #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhairyaMajmudar @Gmin2 @frouioui