Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added types for common folder #544

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Added types for common folder #544

merged 2 commits into from
Jun 11, 2024

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented May 10, 2024 •
edited
Loading

Added types for DisplayList.tsx, Footer.tsx, Navbar.tsx

@Gmin2 Gmin2 requested a review from frouioui as a code owner May 10, 2024 22:32
@Gmin2 Gmin2 marked this pull request as draft May 10, 2024 22:32
@Gmin2 Gmin2 marked this pull request as ready for review May 22, 2024 20:45
@Gmin2 Gmin2 changed the title WIP: added types for common folder Added types for common folder May 24, 2024
@Gmin2 Gmin2 mentioned this pull request Jun 8, 2024
Closed
frouioui
frouioui approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you

@frouioui frouioui merged commit 624134d into vitessio:main Jun 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gmin2 @frouioui