Refactor homepage #567
Merged
Refactor homepage #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
frouioui
reviewed
Jul 8, 2024
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Jad Chahed <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
There are some comments still pending:
- https://github.com/vitessio/arewefastyet/pull/567/files#r1669434668
- https://github.com/vitessio/arewefastyet/pull/567/files#r1669433029
- https://github.com/vitessio/arewefastyet/pull/567/files#r1669435362
Let's get this PR merged and try to fix them when working on the daily page.
Looks good to me overall, thanks a bunch 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?