Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Status Page #570

Merged
merged 24 commits into from
Jul 17, 2024
Merged

Refactor Status Page #570

merged 24 commits into from
Jul 17, 2024

Conversation

Jad31
Copy link
Collaborator

@Jad31 Jad31 commented Jul 12, 2024

What kind of change does this PR introduce?

Issue Number:

  • Closes #___
  • Related to #___
  • Others?

Screenshots/videos:

Before After

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@Jad31 Jad31 requested a review from frouioui as a code owner July 12, 2024 16:19
@Jad31 Jad31 self-assigned this Jul 12, 2024
@Jad31 Jad31 marked this pull request as draft July 12, 2024 16:20
@Jad31 Jad31 changed the title Refactor Status Refactor Status Page Jul 15, 2024
@Jad31 Jad31 marked this pull request as ready for review July 15, 2024 13:42
frouioui
frouioui reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job, the new page and tables look good. I left a few nits and suggestions

website/src/pages/StatusPage/components/ExecutionQueue/ExecutionQueueTable.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/ExecutionQueue/ExecutionsQueueTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/PreviousExecutions/PreviousExecutionsTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/ExecutionQueue/ExecutionsQueueTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/PreviousExecutions/PreviousExecutionsTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/ExecutionQueue/ExecutionQueueTable.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/PreviousExecutions/PreviousExecutionTable.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/PreviousExecutions/PreviousExecutionsTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/ExecutionQueue/ExecutionsQueueTableToolbar.tsx Outdated Show resolved Hide resolved
website/src/pages/StatusPage/components/StatusHero.tsx Outdated Show resolved Hide resolved
@Jad31 Jad31 force-pushed the refactor-status branch from f40a732 to 27893b1 Compare July 16, 2024 21:30
Jad31 and others added 18 commits July 17, 2024 00:04
@Jad31
refactor: hero
31ace76 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
feat: previous execution table
a3c9e78 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
feat: execution queue table
741b957 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
feat: hero responsive
520673f 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
refactor: bar chart color
be444c2 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
refactor: execution queue width
8b9ae5a 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
refactor: execution queue endpoint
ebe9a0a 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
fix: rename commits to executions in hero chart
5c8af0d 
Signed-off-by: Jad Chahed <[email protected]>
@frouioui @Jad31
Update website/src/pages/StatusPage/components/PreviousExecutions/Col…
04ecde8 
…umns.tsx

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui @Jad31
Update website/src/pages/StatusPage/components/ExecutionQueue/Columns…
3ba4081 
….tsx

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui @Jad31
Update website/src/pages/StatusPage/components/ExecutionQueue/Executi…
c9c02c2 
…onsQueueTableToolbar.tsx

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui @Jad31
Update website/src/pages/StatusPage/components/PreviousExecutions/Pre…
153ad42 
…viousExecutionsTableToolbar.tsx

Signed-off-by: Florent Poinsard <[email protected]>
@Jad31
fix: typos and filenames
352c1f8 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
feat: get execution queue from api
852e91b 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
wip: useApiCall hook
7056c27 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
wip: useApiCall hook status
64dd704 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
fix: useApiCall hook everywhere
c91e00a 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
feat: reponsive toolbar
957167d 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31 Jad31 force-pushed the refactor-status branch from c30e1e7 to 957167d Compare July 16, 2024 22:05
Jad31 added 2 commits July 17, 2024 09:36
@Jad31
fix: missing header
928572f 
Signed-off-by: Jad Chahed <[email protected]>
@Jad31
fix: margin on input filter
af82c06 
Signed-off-by: Jad Chahed <[email protected]>
frouioui
frouioui approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired on the review with @Jad31, looks great.

@frouioui frouioui merged commit d3a2485 into main Jul 17, 2024
11 of 13 checks passed
@frouioui frouioui deleted the refactor-status branch July 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

Assignees

@Jad31 Jad31

Labels
LFX 2024 Term 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jad31 @frouioui