Addition of the release summary for v12.0.5 (#10864)

* Addition of the release summary for v12.0.5 Signed-off-by: Florent Poinsard <[email protected]> * Fix upgrade tests - remove unwanted checkout to HEAD Signed-off-by: Florent Poinsard <[email protected]> * Use InitShardMaster only if <= v12 Signed-off-by: Florent Poinsard <[email protected]>
vitessio · Jul 27, 2022 · f1aa624 · f1aa624
1 parent 5fdafec
commit f1aa624
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 7 deletions.
diff --git a/.github/workflows/cluster_endtoend_upgrade.yml b/.github/workflows/cluster_endtoend_upgrade.yml
@@ -94,9 +94,6 @@ jobs:
         mkdir -p /tmp/vitess-build-${{ matrix.project }}/
         cp -R bin /tmp/vitess-build-${{ matrix.project }}/
 
-    - name: Check out HEAD
-      uses: actions/checkout@v2
-
     - name: Run cluster endtoend test ${{ matrix.project }} (create cluster)
       timeout-minutes: 5
       run: |

diff --git a/doc/releasenotes/12_0_5_summary.md b/doc/releasenotes/12_0_5_summary.md
@@ -0,0 +1,9 @@
+## Major Changes
+
+### Upgrade to `go1.17.12`
+
+Vitess `v12.0.5` now runs on `go1.17.12`.
+The patch release of Go, `go1.17.12`, is the reason for this release as it includes important security fixes to packages used by Vitess.
+Below is a summary of this patch release. You can learn more [here](https://go.dev/doc/devel/release#go1.17).
+
+> go1.17.12 (released 2022-07-12) includes security fixes to the compress/gzip, encoding/gob, encoding/xml, go/parser, io/fs, net/http, and path/filepath packages, as well as bug fixes to the compiler, the go command, the runtime, and the runtime/metrics package. [See the Go 1.17.12 milestone](https://github.com/golang/go/issues?q=milestone%3AGo1.17.12+label%3ACherryPickApproved) on our issue tracker for details.
diff --git a/go/test/endtoend/cluster/cluster_process.go b/go/test/endtoend/cluster/cluster_process.go
@@ -26,6 +26,7 @@ import (
 	"os/exec"
 	"os/signal"
 	"path"
+	"regexp"
 	"strconv"
 	"sync"
 	"syscall"
@@ -85,10 +86,10 @@ type LocalProcessCluster struct {
 
 	nextPortForProcess int
 
-	//Extra arguments for vtTablet
+	// Extra arguments for vtTablet
 	VtTabletExtraArgs []string
 
-	//Extra arguments for vtGate
+	// Extra arguments for vtGate
 	VtGateExtraArgs      []string
 	VtGatePlannerVersion planbuilder.PlannerVersion
 
@@ -363,7 +364,7 @@ func (cluster *LocalProcessCluster) StartKeyspace(keyspace Keyspace, shardNames
 		}
 	}
 
-	//Apply VSchema
+	// Apply VSchema
 	if keyspace.VSchema != "" {
 		if err = cluster.VtctlclientProcess.ApplyVSchema(keyspace.Name, keyspace.VSchema); err != nil {
 			log.Errorf("error applying vschema: %v, %v", keyspace.VSchema, err)
@@ -806,3 +807,19 @@ func getCoveragePath(fileName string) string {
 	}
 	return path.Join(covDir, fileName)
 }
+
+func GetMajorVersion(binaryName string) (int, error) {
+	version, err := exec.Command(binaryName, "--version").Output()
+	if err != nil {
+		return 0, err
+	}
+	versionRegex := regexp.MustCompile(`Version: ([0-9]+)\.([0-9]+)\.([0-9]+)`)
+	v := versionRegex.FindStringSubmatch(string(version))
+	if len(v) != 4 {
+		return 0, fmt.Errorf("could not parse server version from: %s", version)
+	}
+	if err != nil {
+		return 0, fmt.Errorf("could not parse server version from: %s", version)
+	}
+	return strconv.Atoi(v[1])
+}
diff --git a/go/test/endtoend/cluster/vtctlclient_process.go b/go/test/endtoend/cluster/vtctlclient_process.go
@@ -47,8 +47,16 @@ func (vtctlclient *VtctlClientProcess) InitShardPrimary(Keyspace string, Shard s
 	// version_upgrade test depends on using older binaries
 	// which means we cannot use the new InitShardPrimary command here
 	// TODO(deepthi): fix after v12.0
+	version, err := GetMajorVersion("vttablet")
+	if err != nil {
+		return err
+	}
+	cmd := "InitShardMaster"
+	if version > 12 {
+		cmd = "InitShardPrimary"
+	}
 	output, err := vtctlclient.ExecuteCommandWithOutput(
-		"InitShardMaster",
+		cmd,
 		"-force", "-wait_replicas_timeout", "31s",
 		fmt.Sprintf("%s/%s", Keyspace, Shard),
 		fmt.Sprintf("%s-%d", Cell, TabletUID))