Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] VReplication: Address SwitchTraffic bugs around replication lag and cancel on error (#17616) #17643

Merged
merged 2 commits into from
Jan 29, 2025

Fix conflicts

1627ef8
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] VReplication: Address SwitchTraffic bugs around replication lag and cancel on error (#17616) #17643

Fix conflicts
1627ef8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

66.42% (-0.02%) compared to f5441d5

View this Pull Request on Codecov

66.42% (-0.02%) compared to f5441d5

Details

Codecov Report

Attention: Patch coverage is 38.31776% with 66 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (f5441d5) to head (1627ef8).
Report is 3 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/server.go 43.75% 36 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 25.00% 21 Missing ⚠️
go/vt/vtctl/workflow/stream_migrator.go 54.54% 5 Missing ⚠️
go/vt/vtctl/workflow/switcher.go 0.00% 2 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-20.0   #17643      +/-   ##
================================================
- Coverage         66.44%   66.42%   -0.02%     
================================================
  Files              1541     1541              
  Lines            244122   244159      +37     
================================================
- Hits             162196   162190       -6     
- Misses            81926    81969      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov