-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add more unit tests for server.go
#17679
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17679 +/- ##
==========================================
+ Coverage 67.75% 67.80% +0.04%
==========================================
Files 1587 1587
Lines 255778 255780 +2
==========================================
+ Hits 173309 173423 +114
+ Misses 82469 82357 -112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
This PR adds some unit tests for some APIs in
server.go
Test coverage on this branch:
Test coverage on main:
Related Issue(s)
go/vt/vtctl/workflow...
#17572Checklist
Deployment Notes