Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTAdmin: update logo and favicon for the new Vitess logos #17715

Merged
merged 2 commits into from
Feb 8, 2025
Merged

VTAdmin: update logo and favicon for the new Vitess logos #17715

merged 2 commits into from
Feb 8, 2025

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Feb 7, 2025 •
edited
Loading

Description

  1. Use new logo in VTAdmin
  2. Change favicon.ico
  3. Reduce height margins slightly in navigation links so all current links are visible without scrolling
  4. Add margin to newly added navigation links which were using different icon styles and hence not aligning

Backporting, so we have the new logos on all supported versions.

After

Screenshot 2025-02-07 at 20 02 22

Before

Screenshot 2025-02-07 at 20 25 38

Related Issue(s)

Fixes #17714

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Switch logo and favicon to new Vitess logo. Update nav styles so all …
6ecf320 
…links are visible and aligned

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 7, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 7, 2025
@rohit-nayak-ps rohit-nayak-ps requested review from deepthi and a team February 7, 2025 19:27
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 7, 2025
@rohit-nayak-ps rohit-nayak-ps added Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 7, 2025
@rohit-nayak-ps
prettier
4021969 
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review February 8, 2025 20:52
@rohit-nayak-ps rohit-nayak-ps merged commit 4c9de0b into vitessio:main Feb 8, 2025
104 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/vtadmin-new-vitess-icon branch February 8, 2025 20:53
vitess-bot pushed a commit that referenced this pull request Feb 8, 2025
@vitess-bot @vitess-bot
VTAdmin: update logo and favicon for the new Vitess logos (#17715)
ac6687b 
Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 8, 2025
Merged
vitess-bot pushed a commit that referenced this pull request Feb 8, 2025
@vitess-bot @vitess-bot
VTAdmin: update logo and favicon for the new Vitess logos (#17715)
7f59fe0 
Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 8, 2025
Merged
vitess-bot pushed a commit that referenced this pull request Feb 8, 2025
@vitess-bot @vitess-bot
VTAdmin: update logo and favicon for the new Vitess logos (#17715)
58eded7 
Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Feb 8, 2025
Merged
rohit-nayak-ps pushed a commit that referenced this pull request Feb 10, 2025
@vitess-bot
[release-20.0] VTAdmin: update logo and favicon for the new Vitess lo…
f074364 
…gos (#17715) (#17724)

Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rohit-nayak-ps pushed a commit that referenced this pull request Feb 10, 2025
@vitess-bot
[release-21.0] VTAdmin: update logo and favicon for the new Vitess lo…
2e5327f 
…gos (#17715) (#17725)

Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rohit-nayak-ps pushed a commit that referenced this pull request Feb 10, 2025
@vitess-bot
[release-19.0] VTAdmin: update logo and favicon for the new Vitess lo…
91b7ef7 
…gos (#17715) (#17723)

Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@notfelineit notfelineit notfelineit approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: VTAdmin is still using the old logo
3 participants
@rohit-nayak-ps @mattlord @notfelineit