test: replace t.Errorf and t.Fatalf with assert and require

[akagami-harsh]

Description

• replace instances of t.Errorf and t.Fatalf with assert and require

Related Issue(s)

• Chore: replace instances of t.Errorf and t.Fatalf with assert and require, respectively #15182

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (10a6916) to head (50c19b5).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17720   +/-   ##
=======================================
  Coverage   67.94%   67.95%           
=======================================
  Files        1586     1586           
  Lines      255173   255195   +22     
=======================================
+ Hits       173389   173405   +16     
- Misses      81784    81790    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shlomi-noach]

Thank you for this pull request! The changes are desired and align with modern testing methodologies which we practice today. I have left multiple comments on how to improve the testing even further, while we're at it, using testify's more user-friendly functionality in some places, or more formal functions in others. These suggestions repeat themselves and so I have not commented on every single change. Would you be open to rewrite those changes as per suggestions?

[shlomi-noach]

BTW, we have a preference for normal git push as opposed to force-push. With force-push it 's difficult to keep track of changes and especially related to code review.

[shlomi-noach]

Please consider this subset of comments for removing superfluous text, as testify's functions already report as much. The same form of comments applies to the entirety of the PR.

[arthurschreiber]

The Sign-off messages in your commits look off? 🤔

[akagami-harsh]

The Sign-off messages in your commits look off? 🤔

I had misconfigured it on my new Linux setup, got it fixed now! 😅

[shlomi-noach]

Again thank you for your efforts. In this review I have dozens of comments. I stopped at some point as I see those are repeating. Some notes:

• Please be very cautious, and use require when the original code otherwise issues a return.
• If using EqualValues, which we encourage, get rid of casting.
• Use ErrorContains to both check that an error is not nil, as well as that it contains some text
• Sometimes you will use require where an assert seems more compatible with the original code.