Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/vt/discovery: configurable logger #17846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

cr: golang style

110f3b8
Select commit
Loading
Failed to load commit list.
Open

go/vt/discovery: configurable logger #17846

cr: golang style
110f3b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 22, 2025 in 0s

67.46% (+0.02%) compared to ef84b32

View this Pull Request on Codecov

67.46% (+0.02%) compared to ef84b32

Details

Codecov Report

Attention: Patch coverage is 68.33333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (ef84b32) to head (110f3b8).

Files with missing lines Patch % Lines
go/vt/discovery/options.go 40.00% 12 Missing ⚠️
go/vt/discovery/healthcheck.go 81.81% 4 Missing ⚠️
go/vt/discovery/topology_watcher.go 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17846      +/-   ##
==========================================
+ Coverage   67.44%   67.46%   +0.02%     
==========================================
  Files        1592     1593       +1     
  Lines      258209   258242      +33     
==========================================
+ Hits       174146   174235      +89     
+ Misses      84063    84007      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.