Skip to content

Commit

Permalink
remove unused parameter
Browse files Browse the repository at this point in the history
Signed-off-by: Andres Taylor <[email protected]>
  • Loading branch information
systay committed Oct 9, 2024
1 parent 594f64d commit 74b891b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
7 changes: 6 additions & 1 deletion go/tester/comparing_query_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ type (

func (f ComparingQueryRunnerFactory) Close() {}

func (f ComparingQueryRunnerFactory) NewQueryRunner(reporter Reporter, handleCreateTable CreateTableHandler, comparer utils.MySQLCompare, cluster *cluster.LocalProcessCluster, table func(name string) (ks string, err error)) QueryRunner {
func (f ComparingQueryRunnerFactory) NewQueryRunner(
reporter Reporter,
handleCreateTable CreateTableHandler,
comparer utils.MySQLCompare,
cluster *cluster.LocalProcessCluster,
) QueryRunner {
return newComparingQueryRunner(reporter, handleCreateTable, comparer, cluster)
}

Expand Down
4 changes: 2 additions & 2 deletions go/tester/tester.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type (
}

QueryRunnerFactory interface {
NewQueryRunner(reporter Reporter, handleCreateTable CreateTableHandler, comparer utils.MySQLCompare, cluster *cluster.LocalProcessCluster, table func(name string) (ks string, err error)) QueryRunner
NewQueryRunner(reporter Reporter, handleCreateTable CreateTableHandler, comparer utils.MySQLCompare, cluster *cluster.LocalProcessCluster) QueryRunner
Close()
}
)
Expand Down Expand Up @@ -101,7 +101,7 @@ func NewTester(
if !t.autoVSchema() {
createTableHandler = func(*sqlparser.CreateTable) func() { return func() {} }
}
t.qr = factory.NewQueryRunner(reporter, createTableHandler, mcmp, clusterInstance, t.findTable)
t.qr = factory.NewQueryRunner(reporter, createTableHandler, mcmp, clusterInstance)

return t
}
Expand Down
9 changes: 7 additions & 2 deletions go/tester/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,13 @@ func NewTracerFactory(traceFile *os.File, inner QueryRunnerFactory) *TracerFacto
}
}

func (t *TracerFactory) NewQueryRunner(reporter Reporter, handleCreateTable CreateTableHandler, comparer utils.MySQLCompare, cluster *cluster.LocalProcessCluster, table func(name string) (ks string, err error)) QueryRunner {
inner := t.inner.NewQueryRunner(reporter, handleCreateTable, comparer, cluster, table)
func (t *TracerFactory) NewQueryRunner(
reporter Reporter,
handleCreateTable CreateTableHandler,
comparer utils.MySQLCompare,
cluster *cluster.LocalProcessCluster,
) QueryRunner {
inner := t.inner.NewQueryRunner(reporter, handleCreateTable, comparer, cluster)
return newTracer(t.traceFile, comparer.MySQLConn, comparer.VtConn, reporter, inner)
}

Expand Down

0 comments on commit 74b891b

Please sign in to comment.