Add new command - planalyze
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
systay
commented
Dec 9, 2024
Signed-off-by: Andres Taylor <[email protected]>
frouioui
approved these changes
Dec 10, 2024
Comment on lines
+174
to
+182
| rb, ok := plan.Instructions.(*engine.Route) | ||
| switch { | ||
| case !ok: | ||
| return Complex | ||
| case rb.Opcode.IsSingleShard(): | ||
| return PassThrough | ||
| } | ||
|
|
||
| return SimpleRouted |
There was a problem hiding this comment.
we should also check for vindex lookup plans and call them as simple
Comment on lines
+2
to
+10
| "keyspaces": { | ||
| "main": { | ||
| "sharded": true, | ||
| "vindexes": { | ||
| "xxhash": { | ||
| "type": "xxhash" | ||
| } | ||
| }, | ||
| "tables": { |
There was a problem hiding this comment.
I believe this only works if the keyspace is defined as main. We have to make it generic if that is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command, vt planalyze, to the vt tool set. It enables analyzing query plans against a candidate VSchema without bringing up a cluster. By running the Vitess planner on a set of queries, it classifies each query into one of four categories:
1. Pass-through: Single-shard queries, fully optimized at the shard level.
2. Simple routed: Single-route plans that avoid costly multi-shard operations.
3. Complex routed: Multi-shard plans that require vtgate-level work, acceptable but potentially slow when frequently used.
4. Unplanable: Queries not currently supported by Vitess planning.
This functionality helps iterate on and refine the VSchema by quickly highlighting queries that require adjustments for improved performance.
Example report can be found here.