-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summarize report as HTML: the gin is out of the bottle #87
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c51e470
Remove old comments
rohit-nayak-ps 0dda164
Add gin based webserver framework. Currently only showing static pages
rohit-nayak-ps 3cc9e45
Make summary attributes public so that they will be part of the marsh…
rohit-nayak-ps 997168d
Summary working on browser launch with just Table count info
rohit-nayak-ps fd39504
Add flag to start server
rohit-nayak-ps ed62d0d
Before trying collapsible sections
rohit-nayak-ps 6584caf
Collapsible sections
rohit-nayak-ps 8d63746
Improve styles. Add format flag
rohit-nayak-ps 9c8e217
make pretty
rohit-nayak-ps 5e11958
Self-review
rohit-nayak-ps 79e718d
go mod tidy
rohit-nayak-ps a514337
Merge conflict
rohit-nayak-ps f24f97d
Fix failing test
rohit-nayak-ps 22e70a0
Remove temp code
rohit-nayak-ps 98fd042
Address review comments
rohit-nayak-ps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand why the web server is called in the root command (and thus for all other commands). We could instead do something similar to what we did for the graphs where we only spin up the web server at the end of summarize when the
*Summaryobject is constructed. That way the logic would be local to summarize and the web server will be created at a time where we already have all the information we wish to render.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I don't necessarily think we need to change this in this PR. We can change it in a subsequent PR if we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason to do it globally is that I was not sure if we wanted to extend the usage of the web server for other purposes, so kept it global. I added the Home/About pages to give a trivial example of what is possible.
I think as we progress we will be persisting state of previous runs and then this website can serve as a way to look at them. Also we should move the graphing to be part of this ...