Documentation: Change uses of varbinary to varchar in example tables for vitess #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
arthmis
changed the title
|
@mattlord do you want this updated as well? They don't make any references to example tables that have changed in PR #17318 in vitess. It also seems this particular doc is different from the |
|
You can ignore the zh files. |
Signed-off-by: arthmis <[email protected]>
Signed-off-by: arthmis <[email protected]>
Signed-off-by: arthmis <[email protected]>
arthmis
force-pushed
the
lmassiah/vitess-issue-15997
branch
from
f428a2e to
35ac846
Compare
|
Ok I've removed the modifications for the files in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These documentation changes were made to align with the changes made in this PR.
Notes
I wasn't sure if I should change these files
I skimmed the surrounding docs and I think it makes sense to update
varbinarytovarcharin those filesI'm also a bit unsure with these two files which have chinese characters. There was a usage of
varbinarysurrounded by chinese characters. I did a rough translation of the surrounding text with google translate and it seems like I didn't need to make changes there.