fix: hoisted-apis-on-top false positives #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rules/hoisted-apis-on-top.ts
Outdated
| parent.parent.type === AST_NODE_TYPES.Program | ||
| ) { | ||
| // The call is already in a top-level position, where it should be. | ||
| // The call is in a valid top-level position. |
There was a problem hiding this comment.
I don't think this is correct for vi.mock() and vi.doUnmock(), though... These should definitely not be valid as far as I'm aware:
const foo = vi.mock('foo')
const bar = await vi.unmock('bar')(fun fact - using this code actually currently causes a parse error when executing vitest due to the runtime substitution leaving stuff dangling after the = sign!)
So I think one would want to special case the behavior just around vi.hoisted() for this issue.
There was a problem hiding this comment.
Good point, I've added a special case around this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #752