This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
Reset grafana password via grafana-cli #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `grafana-cli admin` command was introduced in v 4.1 and allows to change admin user password via cli. This will allow us to set new password in the manifest and rotate it during deployment. Unfortunatelly `grafana-cli` is a little bit silly now and can only read config from `$WORKING_DIR/conf/defaults.ini` and as we have grfana.db in `/var/vcap/store/grafana` we need to point it to it somehow.
Now covered by #22. |
vito
suggested changes
Oct 2, 2017
| cd $(dirname $0)/.. | ||
| mkdir conf | ||
| ln -s $(pwd)/config/config.ini $(pwd)/conf/defaults.ini | ||
| /var/vcap/packages/grafana/bin/grafana-cli admin reset-admin-password <%= p("grafana.admin_password") %> |
There was a problem hiding this comment.
This should probably be escaped using Shellwords.shellescape - passwords can have funny characters in them.
vito
reviewed
Oct 2, 2017
| @@ -5,3 +5,11 @@ $(dirname $0)/create-update-datasources | |||
|
|
|||
| echo "[$(date)] Calling 'create-update-dashboards' ..." | |||
| $(dirname $0)/create-update-dashboards | |||
|
|
|||
| echo "[$(date)] Updating password for admin user" | |||
| ( | |||
There was a problem hiding this comment.
Using a subshell here will prevent a failure within from making the outer script fail. Is that intentional?
May want to use pushd and popd instead, if not.
vito
suggested changes
Oct 2, 2017
|
@combor Are you still interested in getting this cleaned up? If not, I can try to knock out the requested changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The
grafana-cli admincommand was introduced in v 4.1 and allows tochange admin user password via cli.
This will allow to set new password in the manifest and rotate it during deployment.
Unfortunatelly
grafana-cliis a little bit silly now and can only read config from$WORKING_DIR/conf/defaults.iniand as we have grfana.db in/var/vcap/store/grafanawe need to point it there somehow.NOTE This requires grafana 4.1 so version bump is necessary.
How to test