libwww-perl#62 fix warnings during HTTP::Config->match

vitstradal · Feb 17, 2021 · 342a1b5 · 342a1b5
1 parent 02e11bc
commit 342a1b5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/HTTP/Config.pm b/lib/HTTP/Config.pm
@@ -155,8 +155,12 @@ my %MATCH = (
     m_header__ => sub {
         my($v, $k, $uri, $request, $response) = @_;
         return unless $request;
-        return 1 if $request->header($k) eq $v;
-        return 1 if $response && $response->header($k) eq $v;
+        my $req_header = $request->header($k);
+        return 1 if defined($req_header) && $req_header eq $v;
+        if ( $response ) {
+            my $res_header = $response->header($k);
+            return 1 if defined($res_header) && $res_header eq $v;
+        }
         return 0;
     },
     m_response_attr__ => sub {

diff --git a/t/http-config.t b/t/http-config.t
@@ -2,7 +2,9 @@ use strict;
 use warnings;
 
 use Test::More;
-plan tests => 28;
+use Test::Warnings;
+
+plan tests => 29;
 
 use HTTP::Config;
 
@@ -42,6 +44,7 @@ $conf->add_item("not secure", m_secure => 0);
 $conf->add_item("slash", m_host_port => "www.example.com:80", m_path_prefix => "/");
 $conf->add_item("u:p", m_host_port => "www.example.com:80", m_path_prefix => "/foo");
 $conf->add_item("success", m_code => "2xx");
+$conf->add_item("text", m_header__content_type => "text/plain");
 is($conf->find(m_domain => ".com")->{item}, '.com');
 my @found = $conf->find(m_domain => ".com");
 is($#found, 0);
@@ -66,11 +69,11 @@ $response->content_type("text/plain");
 $response->content("Hello, world!\n");
 $response->request($request);
 
-is(j($conf->matching_items($response)), ".com|success|GET|secure|always");
+is(j($conf->matching_items($response)), ".com|success|GET|secure|text|always");
 
 $conf->remove_items(m_secure => 1);
 $conf->remove_items(m_domain => ".com");
-is(j($conf->matching_items($response)), "success|GET|always");
+is(j($conf->matching_items($response)), "success|GET|text|always");
 
 $conf->remove_items;  # start fresh
 is(j($conf->matching_items($response)), "");