Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrated cosmosJS and bank slice #840

Merged
merged 29 commits into from
Nov 6, 2023
Merged

feat: integrated cosmosJS and bank slice #840

merged 29 commits into from
Nov 6, 2023

Conversation

Teja2045
Copy link
Collaborator

@Teja2045 Teja2045 commented Oct 31, 2023 •
edited
Loading

No description provided.

@vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:26am
resolute ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:26am

@Teja2045 Teja2045 requested a review from Hemanthghs October 31, 2023 10:16
charymalloju
charymalloju reviewed Nov 1, 2023
View reviewed changes
frontend/package.json Outdated Show resolved Hide resolved
frontend/src/components/ConnectWalletButton.tsx Outdated Show resolved Hide resolved
frontend/src/store/features/airdrop/airdropService.js Outdated Show resolved Hide resolved
aleem1314
aleem1314 previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't push other module redux state in single PR.

@Teja2045
Copy link
Collaborator Author

Teja2045 commented Nov 1, 2023

Please don't push other module redux state in single PR.

Yeah Aleem, I was thinking the same too. But a lot of things are interdependent (when utils and cosmJS stuff involved). Will it okay in that case

@Teja2045 Teja2045 requested a review from pavania1 November 1, 2023 10:29
@Teja2045 Teja2045 requested a review from aleem1314 November 2, 2023 05:20
@Teja2045 Teja2045 requested a review from aleem1314 November 3, 2023 14:51
charymalloju
charymalloju reviewed Nov 6, 2023
View reviewed changes
frontend/src/store/features/bank/bankSlice.ts Outdated Show resolved Hide resolved
frontend/src/store/features/bank/bankSlice.ts Outdated Show resolved Hide resolved
frontend/src/store/features/bank/bankSlice.ts Outdated Show resolved Hide resolved
frontend/src/store/features/bank/bankSlice.ts Outdated Show resolved Hide resolved
frontend/src/store/features/bank/bankSlice.ts Show resolved Hide resolved
frontend/src/store/features/wallet/walletSlice.ts Outdated Show resolved Hide resolved
frontend/src/store/features/wallet/walletSlice.ts Outdated Show resolved Hide resolved
frontend/src/txns/execute.ts Show resolved Hide resolved
frontend/src/txns/execute.ts Outdated Show resolved Hide resolved
frontend/src/utils/util.ts Outdated Show resolved Hide resolved
@charymalloju charymalloju enabled auto-merge (squash) November 6, 2023 07:30
@charymalloju charymalloju dismissed aleem1314’s stale review November 6, 2023 09:32

blocking merge request

@charymalloju charymalloju disabled auto-merge November 6, 2023 09:33
@charymalloju charymalloju enabled auto-merge (squash) November 6, 2023 09:33
@charymalloju charymalloju disabled auto-merge November 6, 2023 09:39
@charymalloju charymalloju merged commit 9c22a5f into dev Nov 6, 2023
4 checks passed
@charymalloju charymalloju deleted the teja/dev branch November 6, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleem1314 aleem1314 aleem1314 left review comments

@charymalloju charymalloju charymalloju approved these changes

@Hemanthghs Hemanthghs Hemanthghs approved these changes

@pavania1 pavania1 Awaiting requested review from pavania1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Teja2045 @Hemanthghs @charymalloju @aleem1314