fix: Make translations usable #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `tr_key` must be required, otherwise this makes no sense for mappings * longer `translations` should be supported too * `translations` should not be HTML escaped, sometimes they contains links, or words that should be highlighted * `tr_key`s are often longer than 50 char, but they should still be searchable
sveneberth
added
bug(fix)
phorward
approved these changes
Feb 7, 2025
ArneGudermann
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tr_keymust be required, otherwise this makes no sense for mappingstranslationsshould be supported tootr_key,translationsanddefault_textshould not be HTML escaped, sometimes they contains links, or words that should be highlighted with e.g.<strong/>tr_keys are often longer than 50 char, but they should still be searchablenameimplementation, instead of thekey. (E.g. used for tabs in admin)