Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another possible fix to the cores everywhere. I made a
process_type_registry
which includes a ProcessType called'core'
, which is the default core that Composites and Processes can use. People can add to this core if they want to, or make new cores and then just pass a string into Composite to look up the appropriate core.I think there may need to be something smarter with how Processes are assigned cores, without having our users needing to thread cores through everywhere -- I don't want Processes to have to do the whole core=core through the super. Can Composite ensure each Process is given the correct core by setting it rather than having to weave it in through the init?