Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-1135: Fix brevo error handling #108

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

RainbowBunchie
Copy link
Contributor

@RainbowBunchie RainbowBunchie commented Oct 11, 2024

Description

Fix import failing due to error in brevo handeling.
The import was causing an error because of nested try catch blocks and adapting the brevo error message. Now the findContact function returns undefined if no brevo contact was fround instead of an error.

Changeset

[x ] I have verified if my change requires a changeset

Related tasks and documents

COM-1135

@RainbowBunchie RainbowBunchie changed the title Fix brevo error handling COM-1135: Fix brevo error handling Oct 11, 2024
@RainbowBunchie RainbowBunchie marked this pull request as ready for review October 11, 2024 13:33
raphaelblum
raphaelblum previously approved these changes Oct 11, 2024
@raphaelblum raphaelblum merged commit 3c5b342 into main Oct 11, 2024
1 check passed
@raphaelblum raphaelblum deleted the fix-brevo-error-handling branch October 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants