Update to COMET v7 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelblum
previously approved these changes
Nov 4, 2024
raphaelblum
dismissed
their stale review
Merge conflict markers are in the PR
raphaelblum
approved these changes
Nov 4, 2024
RainbowBunchie
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from COMET v6 to v7
Breaking Changes:
@cometpackages@mikro-ormpackages (except@mikro-orm/nestjswhere >= 5.2.3 is required)No changes to the public API were necessary
Note
mjml-react@2to the maintained fork@faire/mjml-react@3. This was necessary because v2 doesn't support React 18 (but is a good thing anyway). Since v3 doesn't have impactful breaking changes, the migration shouldn't be a problem.In the beginning, I split the changes into small commits. So it may make sense to review commit by commit. However, in the end it got a bit messy 😅
https://vivid-planet.atlassian.net/browse/COM-1054