Watch dev-pm.config.js and update in running daemon #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows modifications without having to shutdown the deamon. - processes are not restarted if the script command changes - processes are stopped if the script is removed - processes are not started if a new script is added - identifier for updates is the name of a script
johnnyomair
reviewed
Oct 21, 2024
| Watch dev-pm.config.js and update in running daemon | ||
|
|
||
| This allows modifications without having to shutdown the deamon. | ||
| - processes are not restarted if the script command changes |
There was a problem hiding this comment.
Is this the desired behavior? I think a restart would be more logical
There was a problem hiding this comment.
I don't think I would expect that. And you would also have edge-cases like waitOn or env get modified - should that also trigger a restart?
There was a problem hiding this comment.
I've thought mostly about waitOn and script. Maybe we could change the log to something like "... updated, please restart to apply changes"
Fabian-Fynn
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows modifications without having to shutdown the deamon.