Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve sectionization example #189

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

MurakamiShinyu
Copy link
Member

セクション分けの例を修正しました。

  • セクションを終了させる ## だけの行の例を入れた
  • セクション分けをしない見出しの例を入れた
  • CSSセレクタの body > section > h1:first-child はあまり有用でないと思う(たぶんこの例が書かれたのはVFM v1で見出しの属性がsectionに付く仕様だったので見出しだけの選択がしにくかったことが関係する)ので削除
  • sectionの選択にaria-labelledby属性を使った例を追加
  • sectionの選択に:has()を使った例を追加

Copy link
Member

@akabekobeko akabekobeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akabekobeko akabekobeko merged commit 2c93b90 into main Mar 10, 2024
3 checks passed
@akabekobeko akabekobeko deleted the docs-sectionization branch March 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants