Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide user information into model change #489

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Member

@litvinovg litvinovg commented Feb 11, 2025

VIVO GitHub issue
Should resolve #390 (comment)

What does this pull request do?

Implements an option to provide user information into ModelChange in cases when modification of data is made on in-memory cached models

How should this be tested?

  1. Build and install VIVO, enable audit module
  2. Try to create/delete/edit pages
  3. Create/edit new individuals
  4. Try using SPARQL Update API to insert data
  5. Try using "Edit this individual page to modify individual data"
  6. Try using "Dump and restore"
  7. All of the actions above should be logged in audit interface with real uri of the user, not "http://vivoweb.org/audit/resource/unknown"

Additional Notes:

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Java

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@litvinovg litvinovg force-pushed the userOnThread branch 2 times, most recently from e152980 to 5554e3b Compare February 18, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant