Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from StarRocks:main #8

Open
wants to merge 2,474 commits into
base: main
Choose a base branch
from
Open

[pull] main from StarRocks:main #8

wants to merge 2,474 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 15, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

@github-actions github-actions bot added title needs [type] documentation Improvements or additions to documentation labels Jul 15, 2024
@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually and removed documentation Improvements or additions to documentation title needs [type] labels Jul 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 17, 2024
@pull pull bot removed documentation Improvements or additions to documentation title needs [type] labels Jul 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 18, 2024
@pull pull bot removed documentation Improvements or additions to documentation title needs [type] labels Jul 19, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 19, 2024
@pull pull bot removed documentation Improvements or additions to documentation title needs [type] labels Jul 23, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 23, 2024
@pull pull bot removed documentation Improvements or additions to documentation title needs [type] labels Jul 23, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 23, 2024
@pull pull bot removed documentation Improvements or additions to documentation title needs [type] labels Jul 25, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 25, 2024
@pull pull bot removed the documentation Improvements or additions to documentation label Jul 26, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation title needs [type] labels Jul 26, 2024
@pull pull bot removed the documentation Improvements or additions to documentation label Jan 7, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 7, 2025
@pull pull bot removed the documentation Improvements or additions to documentation label Jan 7, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2025
rohitrs1983 and others added 4 commits January 7, 2025 19:33
Replace pdfcombine with pdftk-java

Signed-off-by: DanRoscigno <[email protected]>
Signed-off-by: Dan Roscigno <[email protected]>
Co-authored-by: Dan Roscigno <[email protected]>
@pull pull bot removed the documentation Improvements or additions to documentation label Jan 8, 2025
## Why I'm doing:
When we convert schema according to specified columns, the sort key idx may be not consistent with origin tablet schema and we need to regenerate the sort key idx[[1]](https://github.com/StarRocks/starrocks/pull/54789/files#diff-24a703fc66db02db41126b8ac8536b8d2144203cb0ce673fe9752a24e59e6e19L47-L54), but the logic is not corrrect.

e.g.
if we create a table like following:
```
CREATE TABLE `agg_test` (
  `k1` bigint(20) NULL COMMENT "",
  `k2` bigint(20) NULL COMMENT "",
  `k3` bigint(20) NULL COMMENT "",
  `k4` bigint(20) NULL COMMENT "",
  `k5` bigint(20) NULL COMMENT "",
  `v1` bigint(20) REPLACE COMMENT ""
) ENGINE=OLAP
AGGREGATE KEY(`k1`, `k2`, `k3`, `k4`, `k5`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
ORDER BY(`k5`, `k4`, `k3`, `k2`, `k1`);
```
the sort key idx in origin schema is `4,3,2,1,0`. And when we generate a new schema `k2,k1,k4,k3,k5,v1`,  the new sort key idx should be `4,2,3,0,1`.

## What I'm doing:
Fix the logic

Fixes StarRocks/StarRocksTest#9060

Signed-off-by: sevev <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2025
@pull pull bot removed the documentation Improvements or additions to documentation label Jan 8, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull documentation Improvements or additions to documentation merge-conflict Resolve conflicts manually title needs [type]
Projects
None yet
Development

Successfully merging this pull request may close these issues.