Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong y axis label position for line/circle in case of both axis dimension #511

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

schaumb
Copy link
Contributor

@schaumb schaumb commented Mar 14, 2024

The best solution would be to put the markers in the middle instead of at the top of the positions where the bars would be

@schaumb schaumb requested a review from simzer March 14, 2024 15:32
@schaumb schaumb marked this pull request as draft March 14, 2024 16:23
@schaumb
Copy link
Contributor Author

schaumb commented Mar 14, 2024

This is not working yet, because orientation change is not recognized as an animation step (jumps)

src/chart/generator/marker.cpp Outdated Show resolved Hide resolved
simzer
simzer previously approved these changes Mar 14, 2024
@schaumb schaumb force-pushed the y_pos_for_circle_both_dim branch from 144872a to 556757f Compare March 14, 2024 19:26
@schaumb schaumb marked this pull request as ready for review March 14, 2024 19:51
@schaumb schaumb requested a review from simzer March 15, 2024 07:35
src/chart/generator/plot.cpp Show resolved Hide resolved
@schaumb schaumb merged commit 6119300 into main Mar 18, 2024
1 check passed
@schaumb schaumb deleted the y_pos_for_circle_both_dim branch March 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants