Axis refactor v12 - Separate AxisChannel properties from Channel properties #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaumb
changed the title
simzer
reviewed
Jan 2, 2025
| @@ -76,6 +76,12 @@ definitions: | |||
| oneOf: | |||
| - type: number | |||
| - { type: string, enum: [auto] } | |||
|
|
|||
| AxisChannel: | |||
| description: | | |||
There was a problem hiding this comment.
Channel props can be inherited:
$extends: Channel| @@ -109,14 +115,18 @@ definitions: | |||
| type: object | |||
| properties: | |||
| x: | |||
| $ref: Channel | |||
| allOf: | |||
There was a problem hiding this comment.
no need for allOf if AxisChannel inherits Channel properties
| @@ -118,9 +118,22 @@ struct ChannelSeriesList | |||
| bool removeSeries(const Data::SeriesIndex &index); | |||
| }; | |||
|
|
|||
| class Channel | |||
| struct AxisChannelProperties | |||
There was a problem hiding this comment.
Wouldn't it make sense if instead of AxisChannelProperties, we had an AxisChannel derived from Channel?
| @@ -15,6 +15,7 @@ namespace Vizzu::Gen | |||
| struct Channels : Refl::EnumArray<ChannelId, Channel> | |||
| { | |||
| using IndexSet = std::set<Data::SeriesIndex>; | |||
| EnumArray<AxisId, AxisChannelProperties> axisProps; | |||
There was a problem hiding this comment.
Wouldn't something like this would be more straight forward:
struct Channels
{
Refl::EnumArray<NonAxisId, Channel> nonAxisChannels;
EnumArray<AxisId, AxisChannel /* inherits Channel */> axisChannels;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.