Add Historical Graph to Building Details Over Any Tracked Column #107
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| this.currGraphData = this.historicData.map((datum: IHistoricData) => ({ | ||
| x: datum.DataYear, | ||
| y: parseFloat((datum as any)[this.colToGraph] as string), |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
| y: parseFloat((datum as any)[this.colToGraph] as string), | ||
| })); | ||
|
|
||
| this.currGraphTitle = (this.graphTitles as any)[this.colToGraph]; |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning
vkoves
changed the title
| <div class="bar-graph-cont"> | ||
| <div | ||
| class="label" | ||
| v-html="graphTitle" |
Check warning
Code scanning / ESLint
disallow use of v-html to prevent XSS attack Warning
|
The pytest bug is a |
|
According this comment on that issue thread, as long as we're using |
This is to prevent Netlify installing Python dependencies, when we do not need those to build the app
|
Getting an intermittent issue of D3 not installing with |
|
@alexkcode I had that happen due to caching or having an existing build, I had to do a fresh Docker build to make sure it installs dependencies. |
|
@alexkcode - do you want to give this a proper final review? |
Description
Adds a basic
BarGraphcomponent (powered by D3) and implements it on the building details page to show a switchable graph of a few of the historically tracked columns. Here's a demo with Marina Towers;Fixes #4
Testing Instructions
Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: