-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module name when generating wrapper #135
Conversation
Can you add a small test for that fix? |
Unfortunately, I have no time for now. I will do that asap |
@spytheman I'm not sure how to add a test for this. The problem existed when executing |
The test would be to translate a C file with just enough in it to show that this fix works, and use relative paths when translating. |
The problem is that test runner script walks through every test file by abs path. I would need to somehow ignore one single file and convert its path to a relative. Not sure if adding this complication to test runner script will pay off |
Just generate the C file as part of your test. Don't make it a permanent file that's checked in. |
I implemented a trick to run tests for both absolute and relative paths, so this should cover this case as well |
Before this PR, the module name was generated wrongly when generating a module for a single file, when the path to this file was relative