move statements to tbl-info so we can deprecate the btreemap cache #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut of scope This prevents us from forgetting to `reset` after using a perma prepared statement.
…the go out of scope" This reverts commit d735e67. We have to revert this given reset and clear_bindings could fail. `drop` has no way for us to cleanly handle a failure so we must force the programmer to manually reset the cached stmt
tantaman
force-pushed
the
stmts-on-tbl-info
branch
from
d61ade8 to
affd2c5
Compare
tantaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.