more clippy

examples/auto_navmesh_avian2d.rs

@@ -172,7 +172,7 @@ fn puck_back_to_start(
                 commands.entity(entity).insert((
                     RigidBody::Static,
                     Path {
-                        current: first.clone(),
+                        current: *first,
                         next: remaining,
                     },
                 ));
@@ -215,10 +215,10 @@ pub fn move_puck(
 pub fn display_puck_path(navigator: Query<(&Transform, &Path)>, mut gizmos: Gizmos) {
     for (transform, path) in &navigator {
         let mut to_display = path.next.iter().map(|v| v.xy()).collect::<Vec<_>>();
-        to_display.push(path.current.clone().xy());
+        to_display.push(path.current.xy());
         to_display.push(transform.translation.xy());
         to_display.reverse();
-        if to_display.len() >= 1 {
+        if !to_display.is_empty() {
             gizmos.linestrip_2d(to_display, palettes::tailwind::YELLOW_400);
         }
     }

examples/demo.rs

@@ -201,7 +201,7 @@ fn setup(mut commands: Commands, mut materials: ResMut<Assets<StandardMaterial>>
         commands.spawn(PointLightBundle {
             point_light: PointLight {
                 shadows_enabled: true,
-                intensity: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 3_000_00.0,
+                intensity: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 300_000.0,
                 range: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 10.0,
                 ..default()
             },

examples/gltf_avian3d.rs

@@ -290,10 +290,7 @@ fn give_target_auto(
             let target_id = commands
                 .spawn((
                     PbrBundle {
-                        mesh: meshes.add(Mesh::from(Sphere {
-                            radius: 0.5,
-                            ..default()
-                        })),
+                        mesh: meshes.add(Mesh::from(Sphere { radius: 0.5 })),
                         material: materials.add(StandardMaterial {
                             base_color: palettes::css::RED.into(),
                             emissive: (palettes::css::RED * 5.0).into(),
@@ -319,7 +316,7 @@ fn give_target_auto(
                 })
                 .id();
             commands.entity(entity).insert(Path {
-                current: first.clone(),
+                current: *first,
                 next: remaining,
             });
             object.0 = Some(target_id);
@@ -343,7 +340,7 @@ fn refresh_path(
             let mut remaining = remaining.to_vec();
             remaining.reverse();
             *path = Path {
-                current: first.clone(),
+                current: *first,
                 next: remaining,
             };
         }
@@ -430,10 +427,10 @@ fn spawn_obstacles(
 fn display_navigator_path(navigator: Query<(&Transform, &Path)>, mut gizmos: Gizmos) {
     for (transform, path) in &navigator {
         let mut to_display = path.next.clone();
-        to_display.push(path.current.clone());
+        to_display.push(path.current);
         to_display.push(transform.translation.xz().extend(0.2).xzy());
         to_display.reverse();
-        if to_display.len() >= 1 {
+        if !to_display.is_empty() {
             gizmos.linestrip(
                 to_display.iter().map(|xz| Vec3::new(xz.x, 0.2, xz.z)),
                 palettes::tailwind::TEAL_400,

examples/helpers/agent3d.rs

@@ -76,7 +76,7 @@ pub fn give_target_to_navigator<const SIZE: u32, const X: u32, const Y: u32>(
         let mut target;
         let delta = if !navmesh.transformed_is_in_mesh(transform.translation) {
             let delta = deltas.entry(entity).or_insert(0.0);
-            *delta = *delta + 0.1;
+            *delta += 0.1;
             *delta
         } else {
             0.0
@@ -105,7 +105,7 @@ pub fn give_target_to_navigator<const SIZE: u32, const X: u32, const Y: u32>(
             continue;
         };
         if let Some((first, remaining)) = path.path.split_first() {
-            let mut remaining = remaining.iter().cloned().collect::<Vec<_>>();
+            let mut remaining = remaining.to_vec();
             remaining.reverse();
             let id = commands
                 .spawn(PbrBundle {
@@ -167,7 +167,7 @@ pub fn refresh_path<const SIZE: u32, const X: u32, const Y: u32>(
             continue;
         };
         if let Some((first, remaining)) = new_path.path.split_first() {
-            let mut remaining = remaining.iter().cloned().collect::<Vec<_>>();
+            let mut remaining = remaining.to_vec();
             remaining.reverse();
             path.current = *first;
             path.next = remaining;

examples/many.rs

@@ -42,7 +42,7 @@ fn main() {
                         ..default()
                     },
                 }),
-            FrameTimeDiagnosticsPlugin::default(),
+            FrameTimeDiagnosticsPlugin,
             LogDiagnosticsPlugin::default(),
             VleueNavigatorPlugin,
         ))
@@ -438,7 +438,7 @@ fn go_somewhere(
             rng.gen_range(0.0..MESH_SIZE.x),
             rng.gen_range(0.0..MESH_SIZE.y),
         );
-        commands.entity(navigator).insert(Target { target: target });
+        commands.entity(navigator).insert(Target { target });
     }
 }
 

examples/primitive_3d.rs

@@ -1,11 +1,6 @@
 use std::f32::consts::{FRAC_PI_2, PI};
 
-use bevy::{
-    color::palettes,
-    math::{vec2, vec3},
-    prelude::*,
-    window::PrimaryWindow,
-};
+use bevy::{color::palettes, math::vec2, prelude::*, window::PrimaryWindow};
 use polyanya::Triangulation;
 use rand::Rng;
 use vleue_navigator::prelude::*;
@@ -89,7 +84,7 @@ fn setup(
         commands.spawn(PointLightBundle {
             point_light: PointLight {
                 shadows_enabled: true,
-                intensity: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 3_000_00.0,
+                intensity: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 300_000.0,
                 range: MESH_WIDTH.min(MESH_HEIGHT) as f32 * 10.0,
                 ..default()
             },

src/obstacles/primitive.rs

@@ -78,16 +78,11 @@ impl ObstacleSource for PrimitiveObstacle {
         let transform = obstacle_transform.compute_transform();
         let to_vec2 = |v: Vec3| v.xy();
 
-        let to_navmesh_vec3 = |v: Vec3| {
-            let v = navmesh_transform.rotation.mul_vec3(v);
-            v
-        };
-
         let to_navmesh = |v: Vec2| {
             let v = v.extend(0.0);
             let v = navmesh_transform.rotation.inverse().mul_vec3(v);
             let v = transform.transform_point(v);
-            to_navmesh_vec3(v)
+            navmesh_transform.rotation.mul_vec3(v)
         };
 
         match self {
@@ -128,7 +123,9 @@ impl ObstacleSource for PrimitiveObstacle {
                 )
                 .map(|v| to_vec2(to_navmesh(v)))
                 .collect::<Vec<_>>();
-                arc.push(to_vec2(to_navmesh_vec3(transform.translation)));
+                arc.push(to_vec2(
+                    navmesh_transform.rotation.mul_vec3(transform.translation),
+                ));
                 arc
             }
             PrimitiveObstacle::CircularSegment(primitive) => copypasta::arc_2d_inner(