feat: support prisdb kvcache data plane metrics #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanjinlong <[email protected]>
Xuanjinlong
force-pushed
the
Xuanjinlong/feat/add-kvcache-metrics
branch
from
232a7b2 to
6d13308
Compare
googs1025
reviewed
May 30, 2025
| @@ -262,7 +262,7 @@ func buildCacheStatefulSet(kvCache *orchestrationv1alpha1.KVCache) *appsv1.State | |||
|
|
|||
| annotations := map[string]string{ | |||
| "prometheus.io/scrape": "true", | |||
| "prometheus.io/port": strconv.Itoa(params.AdminPort), | |||
| "prometheus.io/port": strconv.Itoa(2112), | |||
There was a problem hiding this comment.
Can we extract default values instead of hard-coding them? 🤔
|
I will take a review this week |
Jeffwan
reviewed
Jun 3, 2025
|
|
||
| // kvcache hpkv monitor agent for member registration | ||
| // +kubebuilder:validation:Optional | ||
| HpkvMonitorAgent *RuntimeSpec `json:"hpkvmonitoragent,omitempty"` |
There was a problem hiding this comment.
I kind of forgot we plan to use a separate pod or just a sidecar of kvcache watcher role?
If we plan to use sidecar, we do not necessarily need to introduce the api change here?
Jeffwan
reviewed
Jun 3, 2025
| @@ -358,6 +360,28 @@ func buildCacheStatefulSet(kvCache *orchestrationv1alpha1.KVCache) *appsv1.State | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "kvcache-hpkv-monitor-agent", | |||
| Image: kvCache.Spec.HpkvMonitorAgent.Image, | |||
There was a problem hiding this comment.
I think we can use override mode for this setup. Let me share one example with you.
There was a problem hiding this comment.
could you check this example? https://github.com/vllm-project/aibrix/blob/main/samples/kvcache/infinistore/kvcache_customized.yaml#L42-L89
in this case, you do not need api level change, you can bake the agent container directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Support prisdb kvcache data plane metrics deployment
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.