-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: SparseGPT recipes #1142
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Kyle Sayers <[email protected]> Signed-off-by: Rahul Tuli <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
2f08151
to
e8d94b6
Compare
Do we know why the lm_head in the sparse_2of4_only e2e test was being skipped by the sparse24 bitmask compressor? |
Is this ready for review? still draft |
Signed-off-by: Rahul Tuli <[email protected]>
No it wasn't, now is! |
tests/llmcompressor/transformers/finetune/test_alternate_recipe.yaml
Outdated
Show resolved
Hide resolved
tests/llmcompressor/transformers/finetune/test_alternate_recipe.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Rahul Tuli <[email protected]>
Issue
The following test was failing:
This issue arose due to recent improvements in
SparseGPTModifier
, which changed its default behavior. Previously,lm_head
was silently ignored, but the new updates no longer do so automatically.Fix
The fix involves explicitly updating the affected recipes to include the parameter:
when all layers are targeted. This ensures that
lm_head
is properly excluded and prevents the failure.Example Change
Previously, we relied on regex patterns to target linear layers while ignoring
lm_head
. The updated configuration now explicitly targets linear layers and ignoreslm_head
:This provides a more structured approach and avoids unnecessary regex-based filtering.
Additional Fixes & Improvements
sequential_update
."targets": ["Linear"]
instead of regex matching for better clarity and maintainability.