-
Notifications
You must be signed in to change notification settings - Fork 235
[Multi-Quant] follow-up to README and example #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Brian Dellabetta <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @brian-dellabetta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation and usability of the multi-quantization feature. It introduces a new highlight in the top-level README to inform users about mixed-precision quantization and updates an example to enable seamless switching between sequential and independent quantization pipelines using a command-line flag, facilitating easier testing and exploration of this advanced functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good follow-up for the multi-quantization feature. It introduces a command-line flag --independent
to the example script, making it easier to switch between sequential and independent quantization pipelines. The documentation in the main README.md
and the example's README.md
has been updated accordingly to reflect this change and to better advertise the feature. The implementation is clean and straightforward. I have one suggestion to improve the structure of the example script for better maintainability.
examples/quantization_non_uniform/quantization_multiple_modifiers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Brian Dellabetta <[email protected]>
SUMMARY:
--independent
flag to example so both sequential and independent pipelines can be run in automated testingTEST PLAN:
Example runs, freshly uploaded model checkpoint here