Fix for e2e tests

[horheynm]

SUMMARY:
Issue was caused by trying to save the recipe on modify_save_pretrained. This runs after the session is reset, so no recipe to save.

With SparseAutoModelForCausalLM before the commit, in the same test, recipe is not saved. It is saved in the save_model_and_recipe, which runs after oneshot. We dont do it here anymore because 1. if output path is not provided it doesnt save; 2. if we add again, there will be double save

[Notes]
Another way to fix this is to not to reset the session. This allows us to load and save the recipe. pre-commited SparseAutoModelForCausalLM state does not save the recipe.

TEST PLAN:
Checked that the output from oneshot is the same and pass the e2e tests.

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

[dsikka]

Why is the session being reset in these cases and not our example cases? I'm just surprised we didn't see it then

[horheynm]

@dsikka
In general the session should be reset if you want a clean state - memoryless start.
Dont reset, for example, we run consecutive optimizations (ex. oneshot then finetune).

Here we can change to not to reset, but saving/not saving doesnt affect the test

[dsikka]

Could we update such that we're saving the recipe now please?
It's informative to have that for the e2e cases.

[horheynm]

@dsikka
The recipe now should be saved.
FYI for this e2e tests, saving recipes do not change the outcome so it wont be informative.

[dsikka]

@dsikka The recipe now should be saved. FYI for this e2e tests, saving recipes do not change the outcome so it wont be informative.

We push the outputs and refer to them frequently. Please look at the complete test

[horheynm]

@dsikka The recipe now should be saved. FYI for this e2e tests, saving recipes do not change the outcome so it wont be informative.

We push the outputs and refer to them frequently. Please look at the complete test

If we were referring to it frequently, we should have known recipe wasnt being pushed previously.
I can add recipe creation check on the test in the follow up pr.

[horheynm]

dont merge yet please, not resetting session, so lifecycle is finializing more than once, which raises error.

[horheynm]

Follow up pr to check the contexts of the files, and to make sure recipes exist in the session is here
Will need this pr to land first

#929