Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session_mixin.py #941

Closed
wants to merge 2 commits into from
Closed

Conversation

imrankh46
Copy link

replace tokenizer by processor

if processor is not None:
    processor.save_pretrained(output_dir)```

SUMMARY:
"please provide a brief summary"


TEST PLAN:
"please outline how the changes were tested"

replace tokenizer by processor

```processor = self.processing_class if hasattr(self, "processing_class") else self.tokenizer
if processor is not None:
    processor.save_pretrained(output_dir)```
@kylesayrs
Copy link
Collaborator

kylesayrs commented Dec 2, 2024

Hi @imrankh46, this looks good to me! However, I cannot merge this until

  1. This change is moved to the branch on Update text_generation.py #938
  2. The commented code is removed
  3. The commits are signed for the DCO

@kylesayrs kylesayrs self-assigned this Dec 3, 2024
@kylesayrs
Copy link
Collaborator

Handled by #955

@kylesayrs kylesayrs closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants