Skip to content

Conversation

tao12345666333
Copy link
Contributor

What type of PR is this?

metrics: TTFT in streaming mode

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #128

Release Notes: Yes/No

Copy link

netlify bot commented Sep 23, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 61f0374
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68d961cd75fa970008624abc
😎 Deploy Preview https://deploy-preview-203--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tao12345666333
Copy link
Contributor Author

/hold

@github-actions github-actions bot added the hold label Sep 23, 2025
@rootfs rootfs added this to the v0.1 milestone Sep 26, 2025
Copy link

github-actions bot commented Sep 28, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/extproc/metrics_integration_test.go
  • src/semantic-router/pkg/extproc/request_handler.go
  • src/semantic-router/pkg/extproc/response_handler.go

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/api/router.md
  • website/docs/overview/architecture/envoy-extproc.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@tao12345666333
Copy link
Contributor Author

/unhold

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 28, 2025

/hold cancel

@github-actions github-actions bot removed the hold label Sep 28, 2025
@tao12345666333 tao12345666333 marked this pull request as ready for review September 28, 2025 09:45
@rootfs
Copy link
Collaborator

rootfs commented Sep 28, 2025

@Xunzhuo

@rootfs
Copy link
Collaborator

rootfs commented Sep 28, 2025

@tao12345666333 would you please come up with a PR to explain how to enable streaming?

@rootfs rootfs merged commit fe60472 into vllm-project:main Sep 28, 2025
9 checks passed
@tao12345666333 tao12345666333 deleted the feat-TTFT-in-streaming branch September 28, 2025 18:40
@tao12345666333
Copy link
Contributor Author

@rootfs I've added some notes in the document. https://vllm-semantic-router.com/docs/api/router#streaming-sse-notes

Do you want me to add a dedicated section describing the request for enabling streaming?

In my current implementation, no special configuration is required, uust keep the default settings in the current project; it automatically determines whether to use streaming based on the request headers.

@rootfs
Copy link
Collaborator

rootfs commented Sep 28, 2025

@tao12345666333 gotcha, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: TTFT in streaming mode
4 participants