Skip to content

feat: add tracing to docker compose #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 16, 2025
Merged

feat: add tracing to docker compose #434

merged 10 commits into from
Oct 16, 2025

Conversation

JaredforReal
Copy link
Collaborator

@JaredforReal JaredforReal commented Oct 15, 2025 •
edited
Loading

What this PR does / why we need it:

  • add config.tracing.yaml in config/ as an example.
  • add Jaeger UI to Docker Compose deploy.
  • add tracing to Dashboard.
  • add Jaeger Grafana Datasource, can be used in Grafana Explore.
  • update READMEs.
  • refine Dashboard layout.
image image image

@JaredforReal
add tracing to docker compose
1503c37 
Signed-off-by: JaredforReal <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Oct 15, 2025 •
edited
Loading

✅ Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit e397227
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68f0eee229bde2000843328b
😎 Deploy Preview https://deploy-preview-434--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 config

Owners: @rootfs
Files changed:

  • config/config.tracing.yaml
  • config/config.yaml

📁 dashboard

Owners: @JaredforReal, @Xunzhuo
Files changed:

  • dashboard/frontend/src/pages/TracingPage.tsx
  • dashboard/backend/main.go
  • dashboard/frontend/src/App.tsx
  • dashboard/frontend/src/components/Layout.module.css
  • dashboard/frontend/src/components/Layout.tsx

📁 deploy

Owners: @rootfs, @Xunzhuo
Files changed:

  • deploy/docker-compose/addons/grafana-datasource-jaeger.yaml
  • deploy/docker-compose/README.md
  • deploy/docker-compose/docker-compose.yml

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/tracing/README.md
vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

rootfs
rootfs reviewed Oct 15, 2025
View reviewed changes
@rootfs
Copy link
Collaborator

rootfs commented Oct 15, 2025

@JaredforReal can you also take a look at #329 and see if you can add such app -> router tracing?

@JaredforReal JaredforReal marked this pull request as ready for review October 16, 2025 13:20
@JaredforReal JaredforReal requested a review from Xunzhuo as a code owner October 16, 2025 13:20
@JaredforReal
Copy link
Collaborator Author

JaredforReal commented Oct 16, 2025 •
edited
Loading

@JaredforReal can you also take a look at #329 and see if you can add such app -> router tracing?

@rootfs can we review this pr for now? I will try with a follow-up pr to make it e2e-enable.

@rootfs rootfs merged commit 260d165 into vllm-project:main Oct 16, 2025
9 checks passed
@rootfs
Copy link
Collaborator

rootfs commented Oct 16, 2025

@JaredforReal can you add otel and jaeger to https://github.com/vllm-project/semantic-router/blob/main/website/src/components/AcknowledgementsSection/data.json?

@JaredforReal JaredforReal deleted the tracing branch October 16, 2025 13:36
@JaredforReal
Copy link
Collaborator Author

@JaredforReal can you add otel and jaeger to https://github.com/vllm-project/semantic-router/blob/main/website/src/components/AcknowledgementsSection/data.json?

@rootfs sure! Maybe Grafana, Prometheus, and openwebui can be added here as well.

@rootfs
Copy link
Collaborator

rootfs commented Oct 16, 2025

@JaredforReal can you add otel and jaeger to https://github.com/vllm-project/semantic-router/blob/main/website/src/components/AcknowledgementsSection/data.json?

@rootfs sure! Maybe Grafana, Prometheus, and openwebui can be added here as well.

sounds good!

yossiovadia added a commit to yossiovadia/semantic-router that referenced this pull request Oct 16, 2025
@yossiovadia @claude
feat(openshift): add Jaeger distributed tracing integration
3d876e0 
Add comprehensive distributed tracing support for OpenShift demos:

- Add Jaeger all-in-one deployment manifest
- Add deployment script with configuration instructions
- Add toggle script to enable/disable tracing easily
- Update DEMO-README.md with tracing documentation
- Add DEMO-URLS.md quick reference for all demo URLs

The tracing integration uses OpenTelemetry with OTLP exporters
and provides end-to-end visibility into request flows including:
- Request ingress through Envoy
- ExtProc classification pipeline
- Security checks (jailbreak, PII)
- Category classification
- Model routing decisions
- Cache hits/misses
- Per-span latency breakdown

This leverages the tracing capabilities added in PR vllm-project#434.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Yossi Ovadia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rootfs rootfs rootfs approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo is a code owner

Assignees

@rootfs rootfs

@Xunzhuo Xunzhuo

@JaredforReal JaredforReal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredforReal @rootfs @Xunzhuo