-
Notifications
You must be signed in to change notification settings - Fork 29
[Misc] Add CODEOWNERS to the project. #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
749fd74 to
00265e5
Compare
Signed-off-by: Pooya Moradi <[email protected]>
|
Awesome. If I understand correctly, it will now require an approval from one of the owners before it can be merged right? |
vipannalla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I suggested few owner changes but LGTM lets merge and iterate forward.
| /.buildkite/ @jcyang43 | ||
| /.github/ @jcyang43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add @QiliangCui for CI/CD?
| /tpu_inference/spec_decode/ @py4 @Lumosis | ||
|
|
||
| # Platform Support | ||
| /tpu_inference/platforms/ @xiangxu-google @lsy323 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Siyuan is leaving and Xiang is OOO for few months, can you probably add @wenxindongwork instead who is updating this for DP support.
| /tpu_inference/runner/persistent_batch_manager.py @py4 @xiangxu-google | ||
| /tpu_inference/runner/speculative_decoding_manager.py @py4 @Lumosis | ||
| /tpu_inference/executors/ @xiangxu-google @mrjunwan-lang | ||
| /tpu_inference/core/ @sixiang-google |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add @mrjunwan-lang as secondary owner
|
|
||
| # JAX Model Layers - Attention | ||
| /tpu_inference/layers/jax/ @py4 @bzgoogle @jrplatin @gpolovets1 | ||
| /tpu_inference/layers/vllm/ @hfan @vanbasten23 @lsy323 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to comment below, can you add me instead of Siyuan for various vLLM related things?
No description provided.