[bugfix] some bugs maybe fail to run #896
Open
+89
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianzs
reviewed
May 19, 2025
| port = int(os.environ.get("MASTER_PORT", answer)) # type: ignore | ||
| port = int(os.environ.get("VLLM_DP_MASTER_PORT", answer)) # type: ignore |
There was a problem hiding this comment.
using envs.VLLM_DP_MASTER_PORT is better?
NINGBENZHE
force-pushed
the
main
branch
3 times, most recently
from
9df5c0f to
293eefe
Compare
MengqingCao
reviewed
May 28, 2025
| from torch.distributed import ProcessGroup | ||
| from torch.distributed.distributed_c10d import (Backend, PrefixStore, | ||
| _get_default_timeout, | ||
| is_nccl_available) | ||
| from torch.distributed.rendezvous import rendezvous | ||
| from vllm.config import ParallelConfig | ||
|
|
||
| _DP_GROUP = None |
There was a problem hiding this comment.
There is still process group for dp in vllm now, why we add this here?
There was a problem hiding this comment.
This is used to determine whether to execute the dummy_run of prefill process. The native stateless process does not have global variables to obtain.
| @@ -21,12 +21,18 @@ def get_etp_group() -> GroupCoordinator: | |||
| return _ETP | |||
|
|
|||
|
|
|||
| def model_parallel_initialized(): | |||
| return (_ETP is not None and _EP is not None) | |||
There was a problem hiding this comment.
I think we could use ep without etp, thus this will break this senario
There was a problem hiding this comment.
No. If ETP is not enabled, communication groups will still be created.
Signed-off-by: ningbenzhe1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Solve the bug that the graph mode is the same as p and d, and some other bugs.
Does this PR introduce any user-facing change?
Wouldn't be
How was this patch tested?
Follow the end-to-end test