Skip to content

Commit

Permalink
add arguments to wait for all jobs to be completed and ressources to …
Browse files Browse the repository at this point in the history
…be deployed
  • Loading branch information
mfournioux committed Nov 26, 2024
1 parent 30b7a84 commit 1c29efd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,12 @@ jobs:
kubectl create ns ns-vllm
- name: Run chart-testing (install)
run: helm install --create-namespace --namespace=ns-vllm test-vllm examples/chart-helm -f examples/chart-helm/values.yaml --set secrets.s3endpoint=http://minio:9000 --set secrets.s3bucketname=testbucket --set secrets.s3accesskeyid=$AWS_ACCESS_KEY_ID --set secrets.s3accesskey=$AWS_SECRET_ACCESS_KEY --set image.env[0].name=VLLM_CPU_KVCACHE_SPACE --set resources.requests.cpu=1 --set resources.requests.memory=4Gi --set resources.limits.cpu=2 --set resources.limits.memory=5Gi --set-string image.env[0].value="1" --set-string extraInit.s3modelpath="opt-125m/" --set-string 'resources.limits.nvidia\.com/gpu=0' --set-string 'resources.requests.nvidia\.com/gpu=0' --set-string image.repository="adsai/vllm-cpu-env"
run: helm install --wait --wait-for-jobs --create-namespace --namespace=ns-vllm test-vllm examples/chart-helm -f examples/chart-helm/values.yaml --set secrets.s3endpoint=http://minio:9000 --set secrets.s3bucketname=testbucket --set secrets.s3accesskeyid=$AWS_ACCESS_KEY_ID --set secrets.s3accesskey=$AWS_SECRET_ACCESS_KEY --set image.env[0].name=VLLM_CPU_KVCACHE_SPACE --set resources.requests.cpu=1 --set resources.requests.memory=4Gi --set resources.limits.cpu=2 --set resources.limits.memory=5Gi --set-string image.env[0].value="1" --set-string extraInit.s3modelpath="opt-125m/" --set-string 'resources.limits.nvidia\.com/gpu=0' --set-string 'resources.requests.nvidia\.com/gpu=0' --set-string image.repository="adsai/vllm-cpu-env"

Check failure on line 63 in .github/workflows/lint-test.yaml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:1:250: Double quote to prevent globbing and word splitting

Check failure on line 63 in .github/workflows/lint-test.yaml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:1:295: Double quote to prevent globbing and word splitting

- name: curl test
run: |

Check failure on line 66 in .github/workflows/lint-test.yaml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2006:style:4:6: Use $(...) notation instead of legacy backticks `...`

Check failure on line 66 in .github/workflows/lint-test.yaml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2086:info:12:6: Double quote to prevent globbing and word splitting

Check failure on line 66 in .github/workflows/lint-test.yaml

View workflow job for this annotation

GitHub Actions / actionlint

shellcheck reported issue in this script: SC2077:error:12:12: You need spaces around the comparison operator
kubectl -n ns-vllm get svc
kubectl -n ns-vllm get pods
kubectl port-forward svc/test-vllm-service 8001:80 -n ns-vllm
CODE=`curl --location http://localhost:8001/v1/completions \
--header "Content-Type: application/json" \
Expand Down

0 comments on commit 1c29efd

Please sign in to comment.