[CI/Build] Make mypy job fail when errors occur

Fix `tools/mypy.sh` to fail when any command fails when running in CI. Signed-off-by: Russell Bryant <[email protected]>
vllm-project · Oct 18, 2024 · bf37729 · bf37729
1 parent 32318c7
commit bf37729
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/mypy.yaml b/.github/workflows/mypy.yaml
@@ -33,4 +33,4 @@ jobs:
     - name: Mypy
       run: |
         echo "::add-matcher::.github/workflows/matchers/mypy.json"
-        tools/mypy.sh
+        tools/mypy.sh 1
diff --git a/tools/mypy.sh b/tools/mypy.sh
@@ -2,6 +2,10 @@
 
 CI=${1:-0}
 
+if [ $CI -eq 1 ]; then
+    set -e
+fi
+
 run_mypy() {
     echo "Running mypy on $1"
     if [ $CI -eq 1 ] && [ -z "$1" ]; then