shellcheck: Simplify exit code checks

Simplify a pattern where the exit code was checked by examining the value of `$?`. In these cases, this can be simplified by checking the result of the command directly. SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. Signed-off-by: Russell Bryant <[email protected]>
vllm-project · Aug 27, 2024 · cee03e3 · cee03e3
1 parent 1a75a70
commit cee03e3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 10 deletions.
diff --git a/.buildkite/nightly-benchmarks/scripts/run-lmdeploy-nightly.sh b/.buildkite/nightly-benchmarks/scripts/run-lmdeploy-nightly.sh
@@ -116,8 +116,7 @@ run_serving_tests() {
     bash -c "$server_command" &
 
     # wait until the server is alive
-    wait_for_server
-    if [ $? -eq 0 ]; then
+    if wait_for_server; then
       echo ""
       echo "lmdeploy server is up and running."
     else

diff --git a/.buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh b/.buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh
@@ -293,8 +293,7 @@ run_serving_tests() {
     server_pid=$!
 
     # wait until the server is alive
-    wait_for_server
-    if [ $? -eq 0 ]; then
+    if wait_for_server; then
       echo ""
       echo "vllm server is up and running."
     else

diff --git a/.buildkite/nightly-benchmarks/scripts/run-tgi-nightly.sh b/.buildkite/nightly-benchmarks/scripts/run-tgi-nightly.sh
@@ -121,8 +121,7 @@ run_serving_tests() {
     eval "$server_command" &
 
     # wait until the server is alive
-    wait_for_server
-    if [ $? -eq 0 ]; then
+    if wait_for_server; then
       echo ""
       echo "tgi server is up and running."
     else

diff --git a/.buildkite/nightly-benchmarks/scripts/run-trt-nightly.sh b/.buildkite/nightly-benchmarks/scripts/run-trt-nightly.sh
@@ -102,8 +102,7 @@ run_serving_tests() {
     bash ../.buildkite/nightly-benchmarks/scripts/launch-trt-server.sh "$server_params" "$common_params"
 
     # wait until the server is alive
-    wait_for_server
-    if [ $? -eq 0 ]; then
+    if wait_for_server; then
       echo ""
       echo "trt server is up and running."
     else

diff --git a/.buildkite/nightly-benchmarks/scripts/run-vllm-nightly.sh b/.buildkite/nightly-benchmarks/scripts/run-vllm-nightly.sh
@@ -126,8 +126,7 @@ run_serving_tests() {
     eval "$server_command" &
 
     # wait until the server is alive
-    wait_for_server
-    if [ $? -eq 0 ]; then
+    if wait_for_server; then
       echo ""
       echo "vllm server is up and running."
     else