Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixup Mamba #10004

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

tlrmchlsmth
Copy link
Collaborator

Fix a few typos that were made in #8993.

This went unnoticed because we are not running Mamba integration tests by default (tests/models/decoder_only/language/test_mamba.py).

Copy link

github-actions bot commented Nov 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth requested a review from comaniac November 4, 2024 22:31
Signed-off-by: Tyler Michael Smith <[email protected]>
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 4, 2024
@comaniac comaniac enabled auto-merge (squash) November 4, 2024 23:02
@comaniac comaniac merged commit ad23318 into vllm-project:main Nov 5, 2024
70 of 71 checks passed
@mzusman
Copy link
Contributor

mzusman commented Nov 5, 2024

@tlrmchlsmth Thought CI would catch those, Sorry about that!

JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth added a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants