Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TPU requirements file and pin build dependencies #10010

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Refactor TPU requirements file and pin build dependencies #10010

merged 10 commits into from
Nov 5, 2024

Conversation

richardsliu
Copy link
Contributor

Replaces #9898

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Nov 4, 2024
@bvrockwell
Copy link
Contributor

Hi @robertgshaw2-neuralmagic , please see the fix to docs and dockerfile (much cleaner :))

@bvrockwell
Copy link
Contributor

Looks great, @richardsliu !!

bvrockwell
bvrockwell approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@bvrockwell bvrockwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nit, might want to keep the uninstall step, otherwise looks good!

@richardsliu
uninstall
4445657 
Signed-off-by: Richard Liu <[email protected]>
@richardsliu
remove build from src
b3a6e72 
Signed-off-by: Richard Liu <[email protected]>
@richardsliu
fix format
041e959 
Signed-off-by: Richard Liu <[email protected]>
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) November 5, 2024 00:22
auto-merge was automatically disabled November 5, 2024 00:22

Head branch was pushed to by a user without write access

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2024
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) November 5, 2024 00:23
@richardsliu
fix format
51b98cf 
Signed-off-by: Richard Liu <[email protected]>
auto-merge was automatically disabled November 5, 2024 01:11

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 mentioned this pull request Nov 5, 2024
Closed
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) November 5, 2024 16:47
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic merged commit cd34029 into vllm-project:main Nov 5, 2024
80 checks passed
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@richardsliu @JC1DA
Refactor TPU requirements file and pin build dependencies (vllm-proje…
fc53ba9 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@richardsliu @sumitd2
Refactor TPU requirements file and pin build dependencies (vllm-proje…
64b60a1 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@richardsliu
Refactor TPU requirements file and pin build dependencies (vllm-proje…
a5f07b9 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@richardsliu @mfournioux
Refactor TPU requirements file and pin build dependencies (vllm-proje…
ac26a26 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@richardsliu @tlrmchlsmth
Refactor TPU requirements file and pin build dependencies (vllm-proje…
64c3e7d 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@richardsliu
Refactor TPU requirements file and pin build dependencies (vllm-proje…
6127b46 
…ct#10010)

Signed-off-by: Richard Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic robertgshaw2-neuralmagic approved these changes

@bvrockwell bvrockwell bvrockwell approved these changes

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardsliu @bvrockwell @robertgshaw2-neuralmagic