-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] vllm CLI flags should be ordered for better user readability #10017
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Test
|
dad6135
to
dd5276f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BTW, perhaps we could group some feature specific CLI flags like spec decoding and embeddings in a future PR. |
/retest |
@Isotr0py Hi, There is currently a test case that failed, but from its log, it appears to have nothing to do with this PR. How should I retry these failed test cases. |
You can merge from main branch to re-run the test CI. I will ask for a force merge for this PR tonight if it keeps failing on unrelated tests :) |
FIX vllm-project#10016 Signed-off-by: chaunceyjiang <[email protected]>
Head branch was pushed to by a user without write access
dd5276f
to
f75c936
Compare
ok |
@Isotr0py PTAL. All tests have passed. |
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]>
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…llm-project#10017) Signed-off-by: chaunceyjiang <[email protected]>
FIX #10016
vllm CLI flags should be ordered for better user readability