[CI/Build] Improve mypy + python version matrix #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
mergify
bot
added
documentation
|
This pull request has merge conflicts that must be resolved before it can be |
russellb
force-pushed
the
mypy-python-versions
branch
from
f416483 to
e80e876
Compare
The `mypy` CI job ran using multiple Python versions, though it was always checking for compatibility with Python 3.9 because of the config option in `pyproject.toml`. This change makes it so local usage of `format.sh` will still default to checking for compatibility with the lowest Python version (3.9). The CI job will now check for compatibility with each python version used in the matrix instead of only running `mypy` itself with different versions, but always checking 3.9 compatibility. Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
mypy-python-versions
branch
from
e80e876 to
b773dc1
Compare
DarkLight1337
approved these changes
Nov 7, 2024
github-actions
bot
added
the
ready
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Isotr0py <[email protected]>
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b773dc1 [CI/Build] Improve mypy + python version matrix
commit b773dc1
Author: Russell Bryant [email protected]
Date: Tue Nov 5 15:08:47 2024 +0000