-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Adjust try/except blocks in API impl #10056
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind either way, but maybe we should also do this for chat endpoint to be consistent? (Originally I did it the other way round)
These were changed to separate blocks in vllm-project#9759 but I feel it's cleaner/clearer as a single block. It actually doesn't matter which parts of the block raise the specific exceptions in the except clauses, we still want to handle them in the same way. Signed-off-by: Nick Hill <[email protected]>
67bbfdc
to
cc13590
Compare
Thanks @DarkLight1337 ... I think the chat endpoint is already like this (at least there aren't equivalent separate try/except blocks in the non-streaming impl). |
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
These were changed to separate blocks in #9759 but I feel it's cleaner/clearer as a single block. It actually doesn't matter which parts of the block raise the specific exceptions in the except clauses, we still want to handle them in the same way.