[CI/Build] Always run the ruff workflow #10092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prior PR, vllm-project#9928, modified this workflow to only run when relevant files have changed. However, github is configured to expect and require this workflow to run and pass before a PR can be auto-merged. GitHub configuration is not quite flexible enough to say "require this workflow to pass before merging, but only if we plan to run it." This change is the simplest: just run it always. The change also leaves a comment in the workflow explaining why it is this way. An alternative in the future could be to switch to a different framework for doing auto-merges. Mergify, which is already in use for some things, has flexible enough policy configuration to capture more complex merge criteria. Swithing to it just because of this is not necessary. Signed-off-by: Russell Bryant <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
simon-mo
approved these changes
Nov 6, 2024
github-actions
bot
added
the
ready
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior PR, #9928, modified this workflow to only run when relevant
files have changed. However, github is configured to expect and
require this workflow to run and pass before a PR can be auto-merged.
GitHub configuration is not quite flexible enough to say "require this
workflow to pass before merging, but only if we plan to run it."
This change is the simplest: just run it always. The change also
leaves a comment in the workflow explaining why it is this way.
An alternative in the future could be to switch to a different
framework for doing auto-merges. Mergify, which is already in use for
some things, has flexible enough policy configuration to capture more
complex merge criteria. Swithing to it just because of this is not
necessary.
Signed-off-by: Russell Bryant [email protected]